impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.
Date Sat, 26 Nov 2016 21:22:34 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5154/2/bin/bootstrap_build.sh
File bin/bootstrap_build.sh:

Line 39: # when done building:
> I think deleting the directory when done will be a bit surprising to people
Yeah, I agree. I was thinking of taking out almost everything except the apt-get, export JAVA_HOME,
and buildall.sh - that way it can be run from the same directory the script is in, assuming
the script was acquired by fetching an Impala git repo.

What do you think?


PS2, Line 44: gcc
> We could replace gcc, g++ and make with build-essential. I don't feel stron
I thought this way it would be easier to port to other distributions, or maybe even other
Unixes.


-- 
To view, visit http://gerrit.cloudera.org:8080/5154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If34e398052a61dfda9825b1cf3a918eb61736048
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message