impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4540: Function call in DCHECK crashes scheduler
Date Fri, 25 Nov 2016 15:26:49 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
......................................................................


IMPALA-4540: Function call in DCHECK crashes scheduler

The fix for IMPALA-4494 wrapped the call to
backend_config_.LookUpBackendIp in simple-scheduler.cc:922 in a DCHECK,
effectively disabling it in release builds. This leads to a crash when
backend_ip is empty.

This change makes sure that the function is always called.

Change-Id: Iefbf719e86a59c09c45a5418f6ec0aa5cc4d8c44
Reviewed-on: http://gerrit.cloudera.org:8080/5218
Reviewed-by: Michael Ho <kwho@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Michael Ho: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5218
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefbf719e86a59c09c45a5418f6ec0aa5cc4d8c44
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message