impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4529: speed up parsing of identifiers
Date Thu, 24 Nov 2016 08:03:29 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4529: speed up parsing of identifiers
......................................................................


IMPALA-4529: speed up parsing of identifiers

Instead of using substring(), parseInt() and a try/catch, directly
check the character.

Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Reviewed-on: http://gerrit.cloudera.org:8080/5210
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins

Mime
View raw message