impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4525: fix crash when codegen mem limit exceeded
Date Wed, 23 Nov 2016 23:33:37 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4525: fix crash when codegen mem limit exceeded
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Please wait for Alex's feedback too.

http://gerrit.cloudera.org:8080/#/c/5211/2/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:

PS2, Line 110:     THROW_IF_ERROR_RET(
             :         state.CreateCodegen(), env, JniUtil::internal_exc_class(), result_bytes);
Not your change but this may need to the same clean up too. It's almost like we need a goto.
Feel free to do it in a follow-up patch.


PS2, Line 118:       for (int i = 0; i < expr_ctxs.size(); ++i) {
             :         expr_ctxs[i]->Close(&state);
             :       }
nit: for (ExprContext* ctx : expr_ctxs) ctx->Close(&state);


-- 
To view, visit http://gerrit.cloudera.org:8080/5211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib38d0a44b54c47617cad1b971244f477d344d505
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message