impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState
Date Wed, 23 Nov 2016 23:24:49 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4410: Safer tear-down of RuntimeState
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

Carry +2, last patch didn't include the small test changes needed to make sure query IDs are
unique.

http://gerrit.cloudera.org:8080/#/c/4893/4/be/src/runtime/runtime-state.h
File be/src/runtime/runtime-state.h:

Line 303:   Status CodegenScalarFns();
> let's call this ReleaseResources(), which is also going to be added to a nu
I think the destruction comment is pertinent - it conveys that this is a necessary step before
destroying a runtime state.


http://gerrit.cloudera.org:8080/#/c/4893/4/be/src/runtime/test-env.h
File be/src/runtime/test-env.h:

Line 72:   /// Per-query states with associated block managers. Key is the integer query ID
passed
> key?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie416e4d57240142bf685385299b749c3a6792c45
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message