impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4525: fix crash when codegen mem limit exceeded
Date Wed, 23 Nov 2016 22:13:16 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4525: fix crash when codegen mem limit exceeded
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5211/1/be/src/runtime/plan-fragment-executor.cc
File be/src/runtime/plan-fragment-executor.cc:

Line 268:   return codegen->FinalizeModule();
> We cannot use THROW_IF_ERROR_RET() there because we need to Close() the exp
You're right. If it's too complicated to do the clean-up in this patch, feel free to file
another JIRA and unblock the build for now.


-- 
To view, visit http://gerrit.cloudera.org:8080/5211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib38d0a44b54c47617cad1b971244f477d344d505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message