impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4525: fix crash when codegen mem limit exceeded
Date Wed, 23 Nov 2016 22:03:32 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4525: fix crash when codegen mem limit exceeded
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

The fix looks fine.

Have you tried running tpc_mem_usage_scaling in exhaustive build to make sure no other tests
fail with the new error message from codegen ?

http://gerrit.cloudera.org:8080/#/c/5211/1/be/src/runtime/plan-fragment-executor.h
File be/src/runtime/plan-fragment-executor.h:

Line 281:   /// Must be called after exec_tree_->Prepare() and before exec_tree_->Open().
Update comment about return value.


-- 
To view, visit http://gerrit.cloudera.org:8080/5211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib38d0a44b54c47617cad1b971244f477d344d505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message