impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4523: Correct max VARCHAR size to 65535 (2^16 - 1).
Date Wed, 23 Nov 2016 20:35:30 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4523: Correct max VARCHAR size to 65535 (2^16 - 1).
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5204/1/be/src/runtime/types.h
File be/src/runtime/types.h:

PS1, Line 77: 65535
> :) unbelievable
yes, truly


http://gerrit.cloudera.org:8080/#/c/5204/1/fe/src/main/java/org/apache/impala/catalog/ScalarType.java
File fe/src/main/java/org/apache/impala/catalog/ScalarType.java:

PS1, Line 59: 65535
> Why not (1 << 16) -1 ?
Works for me either way. I guess this bug could have been avoided with your version, so switched
to that (and a few similar places).


-- 
To view, visit http://gerrit.cloudera.org:8080/5204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If76eb45b01692ed360fad8fa1722d56fa06c6c00
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message