impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4518: CopyStringVal() doesn't copy null string
Date Wed, 23 Nov 2016 18:15:09 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5198/1//COMMIT_MSG
Commit Message:

PS1, Line 10: emtpy
> empty
Done


http://gerrit.cloudera.org:8080/#/c/5198/1/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:

Line 151:     *dst = StringVal::null();
> Would be slightly easier to read using an early return here.
IMHO, this is fine as it's structured as a series of if-else stmt.


-- 
To view, visit http://gerrit.cloudera.org:8080/5198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a5b9349dd08556eba5cfedc8c0063cc59f5be03
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message