impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler
Date Wed, 23 Nov 2016 15:00:18 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4494: Fix crash in SimpleScheduler
......................................................................


Patch Set 7:

(4 comments)

Thanks for the review. Addressed the comments and ran git-clang-format. Will rebase next.

http://gerrit.cloudera.org:8080/#/c/5127/6/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

Line 201:   if (topic != incoming_topic_deltas.end()) {
> while you're at it, change this to == and return
Done


http://gerrit.cloudera.org:8080/#/c/5127/7/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

Line 266:     // and tell the statestore. We also ensure that it is always registered with
itself.
> 'registered with itself' sounds a bit odd. '.. that it is part of our backe
Done


Line 269:             local_backend_descriptor_.address.hostname, nullptr));
> odd indentation
Done


Line 606:   BackendConfig coord_only_config;
> make this a class member and initialize in c'tor.
Done, but needed to initialize it in Init() since we need to lookup the local IP address first,
which is done there.


-- 
To view, visit http://gerrit.cloudera.org:8080/5127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1196a2fa47e5954c4a190aa326c135d039a77f
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message