impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables
Date Wed, 23 Nov 2016 03:50:32 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables

Patch Set 3:

File fe/src/main/java/org/apache/impala/analysis/

Line 244:     // Today there is no comprehensive way of enforcing a Sentry authorization policy
> Needs brief comment explaining why this privilege level is required, point 
File fe/src/main/java/org/apache/impala/analysis/

Line 249:     for (String columnName: columnNames_) {
> brief comment and pointer to JIRA

Line 281:       throw new AnalysisException(String.format("Error setting privileges for "
> brief comment and pointer to JIRA

Line 283:           "to issue a GRANT/REVOKE statement.", tableName_.toString()));
> Kudu tables only support the ALL privilege level.
File fe/src/test/java/org/apache/impala/analysis/

Line 907:     // tables.
> also add a positive test case

Line 912:     // IMPALA-4000: ALL privileges on SERVER are not required to create managed
> isn't this already covered somewhere?
I couldn't find a test like this for Kudu. (it would make sense that it would be in this file,
File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test:

Line 296: ---- QUERY
> looks more like an analyzer test

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I183f08ad8ce80deee011a6b90ad67b9cefc0452c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: Yes

View raw message