impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory
Date Wed, 23 Nov 2016 00:44:09 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory

Patch Set 11:

File be/src/codegen/

Line 939:   if (is_corrupt_) {
did the formatter do this?

Line 988:                                               bytes_allocated),
odd indentation

Line 1044:                                               estimated_memory),
odd indentation
File be/src/codegen/llvm-codegen.h:

Line 127: //
augment with brief comment describing memory tracking.

Line 467:   /// expressions), avoid inlining the individual expression evaluation into the
could we make it "avoid inlining for the exprs exceeding this threshold"?

Line 595:   void DestroyIRModule();

although above we simply refer to it as 'module', so maybe simply DestroyModule()?
File be/src/exec/

Line 140:                                 false, std::logical_or<bool>());
odd indentation
File be/src/exec/

Line 302:   if (IsNodeCodegenDisabled()) return;
i find this counterintuitive - why call codegen() if it's disabled (ie, i'd expect those lines
to be reversed).
File fe/src/main/java/org/apache/impala/planner/

Line 824:       mergeFragment.getPlanRoot().setDisableCodegen(true);
what is this for? does exchange ever do codegen?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10015b49da182cb181a653ac8464b4a18b71091
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Silvius Rus <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message