impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
Date Tue, 22 Nov 2016 23:46:27 GMT
Alex Behm has posted comments on this change.

Change subject: Preview: IMPALA-4000: Restricted Sentry authorization for Kudu Tables
......................................................................


Patch Set 2:

(7 comments)

Looks good overall. Still needs some additional tests. Let me know if you want me to point
out the gaps in more detail.

http://gerrit.cloudera.org:8080/#/c/5047/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

Line 244:     analyzer.registerPrivReq(new PrivilegeRequestBuilder().onServer(
Needs brief comment explaining why this privilege level is required, point to JIRA


http://gerrit.cloudera.org:8080/#/c/5047/2/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
File fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java:

Line 249:     if (table instanceof KuduTable) {
brief comment and pointer to JIRA


Line 281:       if (table instanceof KuduTable && privilegeLevel_ != TPrivilegeLevel.ALL)
{
brief comment and pointer to JIRA


Line 283:             "Kudu tables support only all or nothing permissions.");
Kudu tables only support the ALL privilege level.


http://gerrit.cloudera.org:8080/#/c/5047/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java:

Line 907:     AuthzError("create external table tpch.test_tbl3 stored as kudu TBLPROPERTIES
" +
also add a positive test case


Line 912:     AuthzOk("create table tpch.test_tbl3 (i int, j int, primary key (i))" +
isn't this already covered somewhere?


http://gerrit.cloudera.org:8080/#/c/5047/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test:

Line 296: # Not done yet
looks more like an analyzer test


-- 
To view, visit http://gerrit.cloudera.org:8080/5047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I183f08ad8ce80deee011a6b90ad67b9cefc0452c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message