impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates
Date Tue, 22 Nov 2016 22:59:06 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats
updates
......................................................................


Patch Set 6:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4833/6/be/src/exec/filter-context.h
File be/src/exec/filter-context.h:

Line 86:   ExprContext* expr_ctx;
thank you.


http://gerrit.cloudera.org:8080/#/c/4833/6/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 186
what about this?


Line 61: constexpr int BATCHES_PER_FILTER_SELECTIVITY_CHECK = 16;
just curious, but does this really need constexpr?


Line 63:     "ROWS_PER_FILTER_SELECTIVITY_CHECK must be a power of two");
update


Line 677:   RETURN_IF_ERROR(CodegenEvalRuntimeFilters(codegen,
single line? or move all args to new line


http://gerrit.cloudera.org:8080/#/c/4833/6/be/src/util/bloom-filter.h
File be/src/util/bloom-filter.h:

Line 55: /// machines.
a brief sentence on why noexcept here is important.


-- 
To view, visit http://gerrit.cloudera.org:8080/4833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27114869840e268d17e91d6e587ef811628e3837
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message