impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables
Date Tue, 22 Nov 2016 22:37:46 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables

Patch Set 4:

File common/thrift/JniCatalog.thrift:

Line 200:   // If true, an error is raised if an error occurs while adding/dropping a range
> If false, errors while adding/dropping a range partition are ignored.

Line 202:   2: required bool throw_on_error
> ignore_errors?
File fe/src/main/java/org/apache/impala/analysis/

Line 33:   private final boolean throwOnError_;
> ignoreErrors_?

Line 91:     AlterTableStmt.analyzeAddDropRangePartition(rangePartitionSpec_, (KuduTable)
> move analyzeAddDropRangePartition() inside this class, might even just inli
File fe/src/main/java/org/apache/impala/service/

Line 511:   private boolean altersKuduTable(TAlterTableType type) {
> brief comment, something like:

Line 556:     if (setResultSet) {
> dead code block (no more alteration types that produce result sets)
oops, sorry. Done
File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test:

Line 136: select count(*) from tbl_to_alter
> let's also add a count(col) and two where-clause predicates, one that can b

Line 184: # Insert a row that has nulls on non-nullable columns
> non-nullable columns with default values

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I04bc87e04e05da5cc03edec79d13cedfd2012896
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-HasComments: Yes

View raw message