impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales
Date Tue, 22 Nov 2016 20:48:28 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales
......................................................................


Patch Set 2:

So, with this particular issue, we were being tripped up by this logic in generate-schema-statements.py:

   force_reload = options.force_reload or (partition_columns and not alter)

force_reload was set to true because partition_columns had a value, with no corresponding
ALTER clause(s).

After scanning functional_schema_template.sql, it looks like each time we partition, we also
ALTER the table, so I suspect -- though I could be wrong -- we avoid the problem there. Are
you saying we should replace all of those existing ALTER table statements with RECOVER PARTITIONS
anyway? From my limited perspective, I think that's probably not a bad idea. Would that be
worth a second JIRA being filed though?

-- 
To view, visit http://gerrit.cloudera.org:8080/5177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaae97d1d44201aeeacacdd39adbae35753512950
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message