impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow
Date Tue, 22 Nov 2016 10:43:17 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk  overflow
......................................................................


Patch Set 11:

Here's the commit that added CheckAndRotateLogFiles(). Please have a look at it and consider
whether the original reason for having the <=1 check makes sense. I couldn't see why ==1
wouldn't work, but I haven't had much time to look at it.

tree c3d35c8393c3b1384749d141d2b2b3fc01c677b4
parent 07efc0cb17682b2e3218d8b94389f13366f8eca7
author Martin Grund <mgrund@cloudera.com> Mon Jan 5 14:52:49 2015 -0800
committer jenkins <jenkins@gerrit.sjc.cloudera.com> Fri Jan 9 16:51:15 2015 -0800

IMPALA-377: Log Rotation for Impala Processes

This patch enables a simple form of log rotation for Impala. Using the
new command line flag:

    -max_log_files=XX

the specified number of log files is kept for each severity level and
all older log files are removed. The number has to be greater than 1 to
keep at least the current log file open. If set to 0, all log files will
be retained and log rotation is effectively disabled. The rotation is
checked with every interval of "logbufsecs" that is set to a default
value of 5s.

Testing is limited as logging can only be initialized once per process.

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message