impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly
Date Tue, 22 Nov 2016 08:55:03 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4432: Handle internal codegen disabling properly
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5105/7/be/src/runtime/runtime-state.h
File be/src/runtime/runtime-state.h:

PS7, Line 168: The 
> This?
Done


PS7, Line 195: or there are expressions in the fragment
             :   ///    which cannot be interpreted.
> on second thought, maybe #2 makes more sense if worded like you had it: "it
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b6a9ed723c64ba21b861608583cc9b6607d3397
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message