impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly
Date Mon, 21 Nov 2016 23:18:07 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4432: Handle internal codegen disabling properly

Patch Set 6:


Thanks, this is much easier to follow now.  It'd be good for Tim to take another pass now
to make sure it still makes sense to him as well.
File be/src/runtime/runtime-state.h:

PS6, Line 169: HasScalarFnToCodegen
Maybe ScalarFnRequiresCodegen() or similar? i.e. to make it clear that not only do we codegen
these, but that they require codegen.

Line 171:   /// Returns true if there is hint to disable codegen. This can be true for single

Line 180:   /// of the hint and all expressions in the fragment can be interpreted.
given that this depends on the scalar_fns_to_codegen_ state which isn't query-static state,
let's document at what point this routine can be used (e.g. after Prepare() phase or whatever).

Line 194:   ///    which cannot be interpreted.
I think this would be clearer without the double negative. eg.:

1. It's enabled by query option.
2. Enabled by the internal hint and all expressions can be interpreted.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b6a9ed723c64ba21b861608583cc9b6607d3397
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message