impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4502: test partition ddl predicates breaks on non-HDFS filesystems
Date Mon, 21 Nov 2016 20:16:44 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS filesystems
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Carry +2

http://gerrit.cloudera.org:8080/#/c/5164/2/testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-hdfs-only.test
File testdata/workloads/functional-query/queries/QueryTest/partition-ddl-predicates-hdfs-only.test:

Line 19: alter table p1_hdfs partition (j<2, k in ("b", "c")) set cached in 'testPool'
> I think we can get rid of the "show" tests in this file.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8606aa427cb6e50be3395cdde246abb53db5172c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message