impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4478: Initial Kudu client mem tracking for sink
Date Mon, 21 Nov 2016 19:48:33 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5152/1/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:

PS1, Line 34: 100 * 1024 * 1024
> how about pulling this into a #define and using it here and below, to make 
Done


Line 49:     " required (bytes) for a KuduTableSink. This flag is subject to change or removal.");
> Can you add something here that indicates that it is typically 2 * kudu_mut
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5152
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47f17a81e4362ab490019382fedc66c25f07080a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message