impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model
Date Mon, 21 Nov 2016 19:29:55 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5162/1/tests/comparison/leopard/custom_pickle.py
File tests/comparison/leopard/custom_pickle.py:

std file header?


PS1, Line 8: 
           :   Thanks to https://wiki.python.org/moin/UsingPickle/RenamingModules
are we sure licensing is OK?


http://gerrit.cloudera.org:8080/#/c/5162/1/tests/comparison/query.py
File tests/comparison/query.py:

PS1, Line 43: Since all supported
            :     queries may have a WITH clause, getting table expressions from the WITH
clause is
            :     supported here.
FYI, other DML statements won't support WITH clauses.


-- 
To view, visit http://gerrit.cloudera.org:8080/5162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e24da78c49e908449b35f0a6276ebe4236ddba
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message