impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4502: test partition ddl predicates breaks on non-HDFS filesystems
Date Mon, 21 Nov 2016 18:59:09 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS filesystems
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5164/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

Line 396:     if IS_HDFS:
> Instead of this if/else logic, how about we split out only those hdfs-speci
We can do that, but I see a problem with that. This test currently creates, alters and drops
tables and partitions. If we split it up like "all-tests" and "hdfs-specific-tests", we will
need to either:

1) Do the create drop, etc. once in each test file which would make this test take twice as
long on HDFS (already takes about 30+ seconds)

2) Create, drop in the "all-tests" file and just have the "set cached/uncached" queries in
the "hdfs-specific-tests" file. But this would create an interdependence between two test
files, something which we don't do now afaik, and it also doesn't seem like a good practice.

If we're okay with either of the above 2 options, I'll go ahead and make the change.


-- 
To view, visit http://gerrit.cloudera.org:8080/5164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8606aa427cb6e50be3395cdde246abb53db5172c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message