impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.
Date Mon, 21 Nov 2016 17:31:31 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5154/2/bin/bootstrap_build.sh
File bin/bootstrap_build.sh:

Line 39: # when done building:
I think deleting the directory when done will be a bit surprising to people using the script
directly. Seems useful for automated testing though. Maybe it should be a flag to the script?


Or maybe name the script in a way that makes it clear that it's not intended for direct use
- currently it sounds like you would run it and get a working build of Impala.


PS2, Line 44: gcc
We could replace gcc, g++ and make with build-essential. I don't feel strongly though.


-- 
To view, visit http://gerrit.cloudera.org:8080/5154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If34e398052a61dfda9825b1cf3a918eb61736048
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message