impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow
Date Mon, 21 Nov 2016 16:13:37 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk  overflow
......................................................................


Patch Set 10:

(3 comments)

Thanks for applying the fixes. I noticed that there a <=1 where I would expect something
like <1. It'd be great if you could have a look.

http://gerrit.cloudera.org:8080/#/c/4971/10/be/src/common/logging.cc
File be/src/common/logging.cc:

Line 181:   if (max_log_files <= 1) return;
Why do we not allow 1 here? Is there a particular reason why it wouldn't work to retain only
one logfile?


PS10, Line 182: Check audit event log files
              :   // Build glob pattern for input
              :   // e.g. /tmp/impala_audit_event_log_1.0-*
Maybe some of this could go on fewer lines.


Line 188: 
nit: only one newline here.


-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message