impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4440: lineage timestamps can go backwards across daylight savings transitions
Date Mon, 21 Nov 2016 01:29:35 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4440: lineage timestamps can go backwards across daylight savings transitions
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

Looks good to me and since it's a small change I am giving it a +2. Obviously, feel free to
probe someone else for review if you want.

http://gerrit.cloudera.org:8080/#/c/5129/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS1, Line 379: converting from query_exec_state.end_time() 
I hope the Navigator team doesn't have some crazy validation step to ensure that the end_time
of the query matches the ended time in the lineage graph. Maybe send them an email to double
check?


http://gerrit.cloudera.org:8080/#/c/5129/1/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

PS1, Line 316: unix_millis
Maybe rename to something that indicates what this field represents, e.g. query_start_time_in_unix_millis
(maybe too verbose but you see what I mean).


http://gerrit.cloudera.org:8080/#/c/5129/1/tests/custom_cluster/test_lineage.py
File tests/custom_cluster/test_lineage.py:

PS1, Line 38:  Query with order by requires spill to disk if intermediate results don't fit
in mem
Is this comment relevant to the lineage test?


-- 
To view, visit http://gerrit.cloudera.org:8080/5129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34e435fc3511e65bc62906205cb558f2c116a8a9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message