impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.
Date Mon, 21 Nov 2016 01:15:57 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

Patch Set 2: Code-Review+2


I think this a small change so I am giving it a +2. Obviously, feel free to ask for Marcel
to look into it if you want.
Commit Message:

PS2, Line 10: Show column encoding and compression once available
No longer relevant, no?
File fe/src/main/java/org/apache/impala/service/

PS2, Line 39: import;
:) looks as if two import statements got merged into one. Anyways, replace with Guava's String.

PS2, Line 278: else {
             :         defaultValCol.setString_val(kuduColumn.isNullable() ? "NULL" : "");
             :       }
The Kudu team is working  on removing this constraint (i.e. either default or nullable). You
should be able to have a nullable column with a default value. In any case, I think we should
remove this from the else block.
File tests/query_test/

PS2, Line 459: [("b", "string", "", "true", "false", "", "AUTO_ENCODING", "DEFAULT_COMPRESSION",
             :              ("c", "string", "", "false", "false", "", "AUTO_ENCODING", "DEFAULT_COMPRESSION",
long lines

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I83c91b540bc6d27cb4f21535fe12f3f8658c233e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-HasComments: Yes

View raw message