impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables
Date Sat, 19 Nov 2016 00:19:48 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5144/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:

PS1, Line 99: AnalysisException e
Hm, why is this coming back as an AnalysisException? We throw a TableLoadingException so it
might be caught and wrapped somewhere, but I don't see it in analyzer.getTable().


PS1, Line 103: if (e.getMessage().contains(KuduTable.ERROR_OPENING_TABLE_MSG)) return;
String matching isn't ideal. Throwing an exception that is a new subclass of TableLoadingException
(e.g. KuduTableLoadingException), then checking the type would be better.


-- 
To view, visit http://gerrit.cloudera.org:8080/5144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b41fc3c0e95508ab67f1d420b033b02ec75a5da
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message