impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input
Date Fri, 18 Nov 2016 17:09:09 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
......................................................................


Patch Set 15:

(5 comments)

Thanks for the comments, please see PS16.

http://gerrit.cloudera.org:8080/#/c/4863/15/be/src/exec/hdfs-table-sink.cc
File be/src/exec/hdfs-table-sink.cc:

PS15, Line 329: key
> Could do std:move() to avoid copy of string
Done


http://gerrit.cloudera.org:8080/#/c/4863/15/be/src/exec/hdfs-table-sink.h
File be/src/exec/hdfs-table-sink.h:

PS15, Line 168: form
> from
Done


Line 214:   /// Appends all rows in batch to the temporary Hdfs files their respective partitions.
> You're missing a verb in here I think
Rephrased.


Line 269:   PartitionPair* current_clustered_partition_;
> "Only set if 'input_is_clustered_' is true"
Done


Line 272:   /// batches.
> "Only set if 'input_is_clustered_' is true"
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message