impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler
Date Thu, 17 Nov 2016 19:00:32 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4494: Fix crash in SimpleScheduler
......................................................................


Patch Set 1:

(1 comment)

It might be best to special-case the local backend. At a high level this is the most intuitive
thing to do. It seems like we already special-case the local backend to some extent in UpdateMembership().
Otherwise waiting until the membership update is received may make sense.

http://gerrit.cloudera.org:8080/#/c/5127/1/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

Line 300:   BackendConfigPtr backend_config = GetBackendConfig();
I think it would make sense to detect at this point if the backend config doesn't have the
coordinator in it. Then we could wait for the config to be updated (maybe with a timeout)
before failing the query.

Even if we don't crash, it seems very strange for a coordinator to not schedule a query on
itself in the !exec_on_coord case.


-- 
To view, visit http://gerrit.cloudera.org:8080/5127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1196a2fa47e5954c4a190aa326c135d039a77f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message