impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4493: fix string-compare-test when using clang
Date Wed, 16 Nov 2016 21:39:20 GMT
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5110

to look at the new patch set (#2).

Change subject: IMPALA-4493: fix string-compare-test when using clang
......................................................................

IMPALA-4493: fix string-compare-test when using clang

Only the 0 value or sign bit is specified in the return
value for strncmp(), so fix up the test accordingly.

Testing:
- verified the new test still reproduces IMPALA-4436
- verify the new test passes under ASAN build

Change-Id: I5d82ac2bff33fdbf66275fcfc6558c4bc29de5e7
---
M be/src/runtime/string-compare-test.cc
1 file changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/5110/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d82ac2bff33fdbf66275fcfc6558c4bc29de5e7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message