impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present
Date Wed, 16 Nov 2016 15:14:06 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present
......................................................................


Patch Set 2:

> Thanks!
 > 
 > Do you think I should add some code to catalog to validate the
 > value of 'initial_hms_cnxn_timeout_s'? What would be the acceptable
 > range?

Also, what is the recommended way to validate a config parameter in catalog? A simple Preconditions.checkArgument()
call would be sufficient?

Adding this config parameter to the CM UI is another issue. Do you think it should be added
for the 5.10 release or it is not that urgent? I guess, the default value is reasonable for
most users and they can always set it as a safety valve if they have to.

-- 
To view, visit http://gerrit.cloudera.org:8080/5095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I546d8fe9836004832ae40110c9fe22b3e704e11b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message