impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4436: StringValue::StringCompare() should match strncmp()
Date Tue, 15 Nov 2016 16:46:52 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4436: StringValue::StringCompare() should match strncmp()
......................................................................


Patch Set 3: Code-Review+2

Carry and promote Alex's +1.

-- 
To view, visit http://gerrit.cloudera.org:8080/5083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0750f98d8c5ef7d0c0ea279cd1f80b4acbad1be
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message