impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4212: Add sink output expressions to explain output
Date Tue, 15 Nov 2016 04:13:59 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4212: Add sink output expressions to explain output
......................................................................


Patch Set 1:

(5 comments)

looks good, but let's only print the output exprs in explain for explain level 'verbose'.

http://gerrit.cloudera.org:8080/#/c/4783/1/be/src/exec/hdfs-table-sink.cc
File be/src/exec/hdfs-table-sink.cc:

Line 65:         tsink.table_sink.hdfs_table_sink.__isset.skip_header_line_count ?
if you really want to break this up, then please as
...\n
? ...\n
: 0


http://gerrit.cloudera.org:8080/#/c/4783/1/common/thrift/DataSinks.thrift
File common/thrift/DataSinks.thrift:

Line 104:   // Exprs that produce values for slots of output tuple (one expr per slot).
move this right below type, we typically have the common fields precede the 'union' fields


http://gerrit.cloudera.org:8080/#/c/4783/1/fe/src/main/java/org/apache/impala/planner/DataSink.java
File fe/src/main/java/org/apache/impala/planner/DataSink.java:

Line 91:   protected String getOutputExprsString() {
getOutputExprsExplainString()?


Line 95:       for (Expr e : outputExprs_) {
single line


http://gerrit.cloudera.org:8080/#/c/4783/1/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java
File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java:

Line 117:             targetTable_.getFullName(), overwriteStr, partitionKeyStr, getOutputExprsString()));
long line


-- 
To view, visit http://gerrit.cloudera.org:8080/4783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27c3a47d7ee28a9efb1405dd1a6ef9b7a83931f6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message