impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4436: StringValue::StringCompare() should match strncmp()
Date Tue, 15 Nov 2016 01:02:36 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4436: StringValue::StringCompare() should match strncmp()
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5083/1//COMMIT_MSG
Commit Message:

Line 13: falls back to strncmp(), and so the answer will depends on the
typo: will depends


http://gerrit.cloudera.org:8080/#/c/5083/1/be/src/runtime/string-compare-test.cc
File be/src/runtime/string-compare-test.cc:

Line 35: TEST(StringCompareTest, Basic) {
There's a TestCompare in string-value-test.cc. Have you considered putting the test there?


http://gerrit.cloudera.org:8080/#/c/5083/1/be/src/runtime/string-value.inline.h
File be/src/runtime/string-value.inline.h:

Line 51:         return (unsigned char)s1[chars_match] - (unsigned char)s2[chars_match];
static_cast?


-- 
To view, visit http://gerrit.cloudera.org:8080/5083
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0750f98d8c5ef7d0c0ea279cd1f80b4acbad1be
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message