impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking
Date Mon, 14 Nov 2016 21:46:55 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3882: Simplify some query exec state locking

Patch Set 5:

File be/src/service/

Line 279:     return;
> I looked through the code and you're right.
File be/src/service/

PS5, Line 250: {
> Spurious braces.
Makes the scope explicit.
File be/src/service/

PS5, Line 700: NULL
> nullptr

PS5, Line 794: lock_guard<mutex> l(*exec_state->lock());
> Unnecessary lock.
Still, I think it's safe to take the lock as good practice; we generally recommend taking
lock() when accessing member variables for QES. 

Put it this way: GetAnalysisWarnings() doesn't say anything about whether it's thread safe
- so if someone made it not thread-safe in the future, we could get surprised here even though
the method contract hasn't changed at all.

PS5, Line 796: NULL
> nullptr

PS5, Line 802: NULL
> nullptr
File be/src/service/

PS5, Line 568: // Query may have been cancelled during planning. 'status' will reflect that
             :     // UpdateQueryStatus().
> This isn't true. If planning succeeded, and the query was cancelled before 
Good point! Fixed.

PS5, Line 575: RETURN_IF_ERROR(status);
> And this would be RETURN_IF_ERROR(query_status());

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I516357d2b5e9eb83e8209872cbe4c078c778a629
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message