impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4480: zero length region must be as aligned as max align t
Date Mon, 14 Nov 2016 21:25:43 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4480: zero_length_region_ must be as aligned as max_align_t
......................................................................


IMPALA-4480: zero_length_region_ must be as aligned as max_align_t

MemPool::TryAllocateAligned returns memory that might be that aligned,
and it returns &MemPool::zero_length_region_ when called to allocate a
block of size 0.

While I'm here, do some things to make diagnosing test failures from
terminal output easier.

Change-Id: Ia31b27e38897f357478c4eedaab0c787e731b2d4
Reviewed-on: http://gerrit.cloudera.org:8080/5062
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-pool.h
M bin/run-backend-tests.sh
3 files changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia31b27e38897f357478c4eedaab0c787e731b2d4
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message