impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options
Date Mon, 14 Nov 2016 20:07:13 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3726: Add support for Kudu-specific column options
......................................................................


Patch Set 5:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/5026/5/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:

Line 402: nonterminal String ident_or_keyword, ident_or_default;
Can you move ident_or_keyword after the terminals and add a comment that this should be used
instead of IDENT with an explanation why.

I think we should consider reverting these changes in a future compatibility breaking release
because it adds a burden to all future parser changes. Please file a JIRA for that labeled
with "incompatibility".


Line 1498: // TODO: Consider introducing a DEFAULT keyword
remove


http://gerrit.cloudera.org:8080/#/c/5026/1/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java:

Line 242:             "on non-nullable column: '%s'", getColName()));
> Agree. I was thinking of a scenario where Kudu is configured to make column
Let's settle on what to do here.


http://gerrit.cloudera.org:8080/#/c/5026/5/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java:

Line 220:     // TODO: Similar checks are applied for range partition values in
Can we address this immediately after this patch goes in? The code is somewhat tricky/subtle
and we now have it in two places. I still think there should be a final cast after L252 although
it's not strictly necessary to make the currently desired features work.


http://gerrit.cloudera.org:8080/#/c/5026/5/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

Line 59:     encodings = ["ENCODING AUTO_ENCODING", ""]
try some non-default ones?


Line 250:           c INT NOT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,
should we really print AUTO or DEFAULT values?


-- 
To view, visit http://gerrit.cloudera.org:8080/5026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I727b9ae1b7b2387db752b58081398dd3f3449c02
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message