impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4433: Always generate testdata using the same time zone setting
Date Sun, 13 Nov 2016 03:04:54 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4433: Always generate testdata using the same time zone setting
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

carry +2

http://gerrit.cloudera.org:8080/#/c/5058/1/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java
File testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java:

Line 156:     // The TimeZone should be the same no matter what the TimeZone is of the computer
> add comment why
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf7cc796e44e9ff64880f9ae852f40961592f279
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message