impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4433: Always generate testdata using the same time zone setting
Date Sun, 13 Nov 2016 03:04:28 GMT
Hello Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5058

to look at the new patch set (#2).

Change subject: IMPALA-4433: Always generate testdata using the same time zone setting
......................................................................

IMPALA-4433: Always generate testdata using the same time zone setting

Before this change, testdata was generated using the
java.util.TimeZone.getDefault() TimeZone of the machine it was running
on.  This patch standardizes on "America/Los_Angeles", which matches
the existing expected results in the end-to-end tests.

Change-Id: Iaf7cc796e44e9ff64880f9ae852f40961592f279
---
M testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/5058/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5058
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaf7cc796e44e9ff64880f9ae852f40961592f279
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>

Mime
View raw message