impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky
Date Fri, 11 Nov 2016 00:06:47 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py
File tests/conftest.py:

PS1, Line 331:   use_unique_conn = __call_cls_method_if_exists(request.cls, "auto_create_db")
> Instead of hard coding 45 in several places, can you create a constant for 
Added a constant, but it seems weird to mention the JIRA here since this is fairly general
purpose and mentioning the JIRA in the actual test should be enough for anyone who's curious.


http://gerrit.cloudera.org:8080/#/c/5040/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

PS1, Line 205:     # For IMPALA-4454
> Can you mention the Jira here, so that when someone else comes across this 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message