impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof
Date Thu, 10 Nov 2016 23:03:31 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof
......................................................................


Patch Set 3:

> Just want to make sure I understand the bug that you've fixed in
 > this latest patch: previously we called TryAllocateAligned() with
 > an alignment larger than alignof(max_align_t) as a consequence of
 > computing the requested alignment as RoundUpToPowerOfTwo(type_size)
 > rather than alignof(type_size).

almost: we need alignof(type), not alignof(type_size). I figure that's probably what you meant.

-- 
To view, visit http://gerrit.cloudera.org:8080/5022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2dbabcb9af2874d8ed354738243dfca9c492b08
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message