impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile in GetRuntimeProfileStr()
Date Thu, 10 Nov 2016 19:39:37 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4465: Don't hold process wide lock while serializing Runtime Profile
in GetRuntimeProfileStr()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5035/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS1, Line 568: true
why true? Prefer taking the lock when the method returns.


-- 
To view, visit http://gerrit.cloudera.org:8080/5035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad8a1d6644259f177dfb3b29b3ba1ad6a76210a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message