impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable
Date Thu, 10 Nov 2016 18:17:47 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3552: Make incremental stats max serialized size configurable
......................................................................


Patch Set 10: Code-Review+2

(2 comments)

Please hold off on committing until the blocker broken builds are fixed though.

http://gerrit.cloudera.org:8080/#/c/4867/10//COMMIT_MSG
Commit Message:

PS10, Line 21: amends the TBackendConfig
introduces a TBackendGflags


http://gerrit.cloudera.org:8080/#/c/4867/10/be/src/util/backend-gflag-util.cc
File be/src/util/backend-gflag-util.cc:

Line 76: }
it's too bad we can't autogenerate this file (and the thrift structure) so that new options
are available to the FE automatically, but this is okay for now and definitely and improvement.


-- 
To view, visit http://gerrit.cloudera.org:8080/4867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-Reviewer: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message