impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Improve Kudu UPSERT test coverage
Date Thu, 10 Nov 2016 16:46:16 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: Improve Kudu UPSERT test coverage
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4953/4//COMMIT_MSG
Commit Message:

PS4, Line 9: This patch also introduces a new test section 'DML_RESULTS', which
           : takes the name of a table as a comment and the contents of the
           : table as its body and then verifies that the body 
> let's remove this; sorry if my previous comments were confusing
Done


http://gerrit.cloudera.org:8080/#/c/4953/4/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test:

PS4, Line 23: NumModifiedRows: 1
> I realized in my own change that all of these regex checks can be simplifie
Done


http://gerrit.cloudera.org:8080/#/c/4953/4/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

PS4, Line 341:  Combining 'RESULTS' with 'DML_RESULTS"
> add a comment that this isn't supported for now because __verify_results_an
Done


PS4, Line 357: UNTIME_PRO
> Please add a comment about the limit, e.g .to make sure the queries aren't 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4953
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message