impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3552: Make incremental stats max serialized size configurable
Date Thu, 10 Nov 2016 06:15:11 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3552: Make incremental stats max serialized size configurable
......................................................................


Patch Set 9:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4867/9/be/src/service/frontend.cc
File be/src/service/frontend.cc:

Line 32: DEFINE_bool(load_catalog_at_startup, false, "if true, load all catalog data at startup");
> move to catalog.cc
Actually this is used no where else. Removed.


http://gerrit.cloudera.org:8080/#/c/4867/9/be/src/util/backend-gflag-util.cc
File be/src/util/backend-gflag-util.cc:

Line 50: Status GetThriftBackendConfigBytes(JNIEnv* jni_env, jbyteArray* cfg_bytes) {
> GetThriftBackendGflags()
Done


Line 51:   TBackendStartupParams cfg;
> TBackendGflags
Done


http://gerrit.cloudera.org:8080/#/c/4867/9/common/thrift/BackendConfig.thrift
File common/thrift/BackendConfig.thrift:

Line 1: // Licensed to the Apache Software Foundation (ASF) under one
> BackendGflags.thrift
Done


http://gerrit.cloudera.org:8080/#/c/4867/9/fe/src/main/java/org/apache/impala/service/BackendConfig.java
File fe/src/main/java/org/apache/impala/service/BackendConfig.java:

Line 53:   // Inits the auth_to_local configuration in static KerberosName class.
> the static KerberosName
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-Reviewer: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message