impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2
Date Tue, 08 Nov 2016 23:24:21 GMT
Matthew Jacobs has uploaded a new patch set (#2).

Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2

IMPALA-3710: Kudu DML should ignore conflicts, pt2

Second part of IMPALA-3710, which removed the IGNORE DML
option and changed the following errors on Kudu DML
operations to be ignored:
1) INSERT where the PK already exists
2) UPDATE/DELETE where the PK doesn't exist

This changes other data-related errors to be ignored as
3) NULLs in non-nullable columns, i.e. null constraint
4) Rows with PKs that are in an 'uncovered range'.

It became clear that we can't differentiate between (3) and
(4) because both return a Kudu 'NotFound' error code. The
Impala error codes have been simplified as well: we just
report a generic KUDU_NOT_FOUND error in these cases.

This also adds some metadata to the thrift report sent to
the coordinator from sinks so the total number of rows with
errors can be added to the profile. Note that this does not
include a breakdown of error counts by type/code because we
cannot differentiate between all of these cases yet.

An upcoming change will add this new info to the beeswax
interface and show it in the shell output (IMPALA-3713).

Testing: Updated kudu_crud tests to check the number of rows
with errors.

Change-Id: I4eb1ad91dc355ea51de261c3a14df0f9d28c879c
M be/src/exec/
M be/src/exec/data-sink.h
M be/src/exec/
M be/src/exec/
M be/src/exec/kudu-table-sink.h
M be/src/runtime/
M common/thrift/ImpalaInternalService.thrift
M common/thrift/
M testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test
9 files changed, 179 insertions(+), 101 deletions(-)

  git pull ssh:// refs/changes/85/4985/2
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4eb1ad91dc355ea51de261c3a14df0f9d28c879c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Matthew Jacobs <>

View raw message