impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations
Date Tue, 08 Nov 2016 22:29:15 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4433: Fix undefined NDV calculations
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Would be good to have someone else take a look in case there might be other consequences for
tests.

http://gerrit.cloudera.org:8080/#/c/5004/1/be/src/udf_samples/hyperloglog-uda.cc
File be/src/udf_samples/hyperloglog-uda.cc:

PS1, Line 81:               (sizeof(hash_value) * CHAR_BIT - HLL_PRECISION));
            :   dst->ptr[idx] = ::max(dst->ptr[idx], first_one_bit);
> It's in Impala proper, while it seems like the non-test files in this direc
Oops, thought I deleted this comment (I realised that point halfway through writing it)


-- 
To view, visit http://gerrit.cloudera.org:8080/5004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8460bc3f7e510ce07b8673387c9440accc432abe
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Amos Bird <amosbird@gmail.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message