impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2
Date Tue, 08 Nov 2016 21:07:57 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4985/1/be/src/exec/data-sink.cc
File be/src/exec/data-sink.cc:

Line 161:       ss << "NumRowErrors: " << stats.kudu_stats.num_row_errors <<
endl;
> It is unfortunate and probably not helpful enough, but I'm very worried abo
Agree that misinformation is worse. Can you add a comment to the counter similar to what you
responded here? Just as an explanation why all errors are purposely aggregated.


http://gerrit.cloudera.org:8080/#/c/4985/1/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 430: // TODO: Refactor to reflect usage by other DML statements.
> Yeah I'll go ahead and do this if you think the strategy is otherwise OK.
I think it makes sense to do this non-functional rename/refactoring in a separate patch.


Line 445:   // The latest observed Kudu timestamp reported by the KuduSession at this partition.
> Hm yeah I guess it's not great to call this a partition... Table I think mi
reported by the local KuduSession?


-- 
To view, visit http://gerrit.cloudera.org:8080/4985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eb1ad91dc355ea51de261c3a14df0f9d28c879c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message