impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4446: expr-test fails under ASAN
Date Tue, 08 Nov 2016 19:05:08 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4446: expr-test fails under ASAN
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5000/1/be/src/exprs/like-predicate.cc
File be/src/exprs/like-predicate.cc:

PS1, Line 357: string pattern_str(reinterpret_cast<const char*>(pattern_value.ptr),
pattern_value.len);
long line - clang-format?


-- 
To view, visit http://gerrit.cloudera.org:8080/5000
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac10d34dd6463ab52e41de1002ef065cfe63a20
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message